Conversation
cd991dc to
bf5d341
Compare
|
As far as I can tell, the two JDK8/IBM related commits aren't specific to Windows so they shouldn't be associated with ARTEMIS-6116 either. |
You're right - moving these to a separate issue as well. |
34fe053 to
4660c46
Compare
|
@jbertram you mentioned you tested my changes as well - what Windows version are you using? I am getting different results on Windows10 and Windows11 it seems. |
|
I was testing on Windows 10, but I went back and tested again after you responded and it looks like the slashes are indeed a real problem. |
79538d1 to
7fb5cf0
Compare
|
@jbertram can you review this again and let me know if anything needs changing? I think I solved everything, tested on win10 and win11. Also, the last commit is solving an edge case. Error only happens when user does not have permissions to create symlinks. p.s. does it make sense to create a github job to run builds/tests on Windows? |
Reduce network timeout checked because windows reports lower timeouts
Fixes issues related to backslashes
|
Rebased on main. |
|
Most of this looks good. I only have qualms with two commits:
I'll merge the rest but I'm dropping these two commits. |
Fixes tests on windows.