Skip to content

ARTEMIS-6116 Fix tests for windows OS - #6513

Closed
GChuf wants to merge 15 commits into
apache:mainfrom
GChuf:ARTEMIS-6116
Closed

GChuf wants to merge 15 commits into
apache:mainfrom
GChuf:ARTEMIS-6116

Conversation

@GChuf

@GChuf GChuf commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Fixes tests on windows.

Comment thread pom.xml Outdated
@GChuf
GChuf force-pushed the ARTEMIS-6116 branch 5 times, most recently from cd991dc to bf5d341 Compare June 20, 2026 10:42
@jbertram

jbertram commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

As far as I can tell, the two JDK8/IBM related commits aren't specific to Windows so they shouldn't be associated with ARTEMIS-6116 either.

@GChuf

GChuf commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

As far as I can tell, the two JDK8/IBM related commits aren't specific to Windows so they shouldn't be associated with ARTEMIS-6116 either.

You're right - moving these to a separate issue as well.

@GChuf
GChuf force-pushed the ARTEMIS-6116 branch 3 times, most recently from 34fe053 to 4660c46 Compare June 25, 2026 07:34
@GChuf

GChuf commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@jbertram you mentioned you tested my changes as well - what Windows version are you using? I am getting different results on Windows10 and Windows11 it seems.

@jbertram

Copy link
Copy Markdown
Contributor

I was testing on Windows 10, but I went back and tested again after you responded and it looks like the slashes are indeed a real problem.

@GChuf
GChuf force-pushed the ARTEMIS-6116 branch 4 times, most recently from 79538d1 to 7fb5cf0 Compare July 11, 2026 10:08
@GChuf

GChuf commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

@jbertram can you review this again and let me know if anything needs changing? I think I solved everything, tested on win10 and win11.
There's only 1 remaining test failing in Artemis Server (on my machines, anyway), but that's because running "main" without arguments hangs on windows instead of exiting:
MainTest.testNull » Timeout testNull() timed out after 5 seconds
Maybe we should solve that behavior in the server code, not just "fix" the test scenario.

Also, the last commit is solving an edge case. Error only happens when user does not have permissions to create symlinks.

p.s. does it make sense to create a github job to run builds/tests on Windows?

@GChuf

GChuf commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Rebased on main.

@jbertram

jbertram commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Most of this looks good. I only have qualms with two commits:

  • "Release file handles in MessageSerializerTest" - this appears to be masking an actual leak, at least in regards to the Producer.
  • "Replace ':' in filename with '_'" - this appears to have genuine upgrade problems. Lock files created with : will no longer be loaded once this code is changed. This change should include a note in versions.adoc as well as code to detect & rename existing files using :. Alternatively, it may be simpler to just detect the OS and adjust accordingly so that non-Windows use-cases didn't need to change.

I'll merge the rest but I'm dropping these two commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants